Merging a Pull Request from GitHub – Live Coding with Jesse

  • Post comments:4 Comments



I have a pull request that needs merged. This may be basic for some people, but I thought it would be helpful to see for those who have never done it.

Also, as always, Q and A at the end!

See a professional front-end developer at work. Unscripted. Mistakes included.

Live Site: https://catechetics.com
Repo: https://github.com/fus-marcom/ci-react
Trello Board for this Project: https://trello.com/b/oD4BYdZk

React: https://facebook.github.io/react/
Next.js: https://github.com/zeit/next.js/
Materialize: http://materializecss.com/

Twitter: https://twitter.com/JesseRWeigel
Youtube: https://www.youtube.com/c/JesseWeigel29

Code Editor: https://atom.io/
Terminal: https://www.iterm2.com/
Project Management: https://trello.com

Learn to code for free and get a developer job: https://www.freecodecamp.com

Read hundreds of articles on programming: https://medium.freecodecamp.com

source

This Post Has 4 Comments

  1. Boomer

    Hi Jesse,

    I might actually do a pull request. I'm a bit of a noob when it comes to GH and collaborating but will keep it simple for the initial and build it up over time.

  2. Boomer

    Hi Jesse, also a good house keeping task in class components is to destructure this.props at the top of the render() method to help DRY your components (easier to read as well). i.e for Layout:

    render() {
    const { title, description, headerType, children} = this.props;

    <Head title={title} description={description} />
    ….
    }

    You can also rename while destructuring as well as target nested properties. React Router 4 provides good examples of destructuring in stateless functional components.

Leave a Reply